the-other-tim-brown commented on code in PR #14314:
URL: https://github.com/apache/hudi/pull/14314#discussion_r2554403683
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/common/TestHoodieInternalRowUtils.scala:
##########
@@ -306,14 +307,14 @@ class TestHoodieInternalRowUtils extends FunSuite with
Matchers with BeforeAndAf
.updateColumnType("col51", Types.DecimalType.get(18, 9))
.updateColumnType("col6", Types.StringType.get)
val newSchema = SchemaChangeUtils.applyTableChanges2Schema(internalSchema,
updateChange)
- val newAvroSchema = AvroInternalSchemaConverter.convert(newSchema,
avroSchema.getName)
- val newRecord = HoodieAvroUtils.rewriteRecordWithNewSchema(avroRecord,
newAvroSchema, new HashMap[String, String])
- assert(GenericData.get.validate(newAvroSchema, newRecord))
+ val newHoodieSchema = InternalSchemaConverter.convert(newSchema,
avroSchema.getName)
Review Comment:
`newSchema` is already defined in this scope so you cannot name this output
`newSchema` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
