rahil-c commented on code in PR #14313:
URL: https://github.com/apache/hudi/pull/14313#discussion_r2556564912
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieBootstrapFileReader.java:
##########
@@ -61,9 +61,10 @@ public Set<Pair<String, Long>> filterRowKeys(Set<String>
candidateRowKeys) {
}
@Override
- public ClosableIterator<HoodieRecord<T>> getRecordIterator(Schema
readerSchema, Schema requestedSchema) throws IOException {
+ public ClosableIterator<HoodieRecord<T>> getRecordIterator(HoodieSchema
readerSchema, HoodieSchema requestedSchema) throws IOException {
ClosableIterator<HoodieRecord<T>> skeletonIterator =
skeletonFileReader.getRecordIterator(readerSchema, requestedSchema);
- ClosableIterator<HoodieRecord<T>> dataFileIterator =
dataFileReader.getRecordIterator(HoodieAvroUtils.removeMetadataFields(readerSchema),
requestedSchema);
+ // TODO boundary for now to revisit HoodieAvroUtils in later pr to use
HoodieSchema
Review Comment:
Just to confirm you are reffering to the comment or something? When I
checked the diff on my side in my IDE the `dataFileReader.getRecordIterator` is
not removed
<img width="1487" height="304" alt="Screenshot 2025-11-24 at 6 37 45 AM"
src="https://github.com/user-attachments/assets/b5e18130-127f-45c6-954d-a56a8a1acb94";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
