rahil-c commented on code in PR #14313:
URL: https://github.com/apache/hudi/pull/14313#discussion_r2556604153
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieBootstrapFileReader.java:
##########
@@ -72,9 +73,10 @@ protected void setPartitionPathField(int position, Object
fieldValue, T row) {
};
}
- public ClosableIterator<HoodieRecord<T>> getRecordIterator(Schema schema)
throws IOException {
+ public ClosableIterator<HoodieRecord<T>> getRecordIterator(HoodieSchema
schema) throws IOException {
ClosableIterator<HoodieRecord<T>> skeletonIterator =
skeletonFileReader.getRecordIterator(schema);
ClosableIterator<HoodieRecord<T>> dataFileIterator =
dataFileReader.getRecordIterator(dataFileReader.getSchema());
+ // TODO boundary for now to revisit in later pr to use HoodieSchema
Review Comment:
yes let me remove
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieBootstrapFileReader.java:
##########
@@ -72,9 +73,10 @@ protected void setPartitionPathField(int position, Object
fieldValue, T row) {
};
}
- public ClosableIterator<HoodieRecord<T>> getRecordIterator(Schema schema)
throws IOException {
+ public ClosableIterator<HoodieRecord<T>> getRecordIterator(HoodieSchema
schema) throws IOException {
ClosableIterator<HoodieRecord<T>> skeletonIterator =
skeletonFileReader.getRecordIterator(schema);
ClosableIterator<HoodieRecord<T>> dataFileIterator =
dataFileReader.getRecordIterator(dataFileReader.getSchema());
+ // TODO boundary for now to revisit in later pr to use HoodieSchema
Review Comment:
yes let me remove the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
