the-other-tim-brown commented on code in PR #14312:
URL: https://github.com/apache/hudi/pull/14312#discussion_r2557282906


##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java:
##########
@@ -389,6 +517,9 @@ public HoodieSchemaType getType() {
    * @return Option containing the schema name, or Option.empty() if none
    */
   public Option<String> getName() {
+    if (avroSchema.getLogicalType() != null) {
+      return Option.of(type.name().toLowerCase(Locale.ENGLISH));

Review Comment:
   It is optional, the default will be based on the system default so it is 
typically best to provide a parameter for guaranteed consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to