the-other-tim-brown commented on code in PR #14312:
URL: https://github.com/apache/hudi/pull/14312#discussion_r2557740577


##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaType.java:
##########
@@ -192,6 +233,7 @@ public boolean isNumeric() {
       case LONG:
       case FLOAT:
       case DOUBLE:
+      case DECIMAL:

Review Comment:
   To me the time, timestamp, and date are not numeric. I think we don't rely 
on that heavily so we can revisit whether we even expose this method after 
migrating.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to