the-other-tim-brown commented on code in PR #14364:
URL: https://github.com/apache/hudi/pull/14364#discussion_r2565520535
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaProvider.java:
##########
@@ -49,10 +49,10 @@ protected SchemaProvider(TypedProperties props,
JavaSparkContext jssc) {
}
@PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
- public abstract Schema getSourceSchema();
+ public abstract HoodieSchema getSourceSchema();
Review Comment:
@yihua and @bvaradar since these are public facing API methods, should I
instead preserve the `getSourceSchema` and `getTargetSchema` and then add new
methods for `getSourceHoodieSchema` and `getTargetHoodieSchema` which will
default to calling the existing methods like,
`HoodieSchema.fromAvroSchema(getSourceSchema)`, so any user provided schema
provider will continue to work as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
