balaji-varadarajan-ai commented on code in PR #14364:
URL: https://github.com/apache/hudi/pull/14364#discussion_r2566051615
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SchemaProvider.java:
##########
@@ -49,10 +49,10 @@ protected SchemaProvider(TypedProperties props,
JavaSparkContext jssc) {
}
@PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
- public abstract Schema getSourceSchema();
+ public abstract HoodieSchema getSourceSchema();
Review Comment:
Yes, All SchemaProviders APIs needs to be intact and the delegation makes
sense. What we would need is exiting APIs getSourceSchema() and
getTargetSchema() should only be called from getHoodieSourceSchema() and
getHoodieTargetSchema() and not from anywhere else in the production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
