nsivabalan commented on code in PR #14357:
URL: https://github.com/apache/hudi/pull/14357#discussion_r2566306820
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -348,6 +348,8 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
// Eat exception as we do not want to mask the original exception that
can happen
LOG.error("Unable to close log format reader", ioe);
}
+ LOG.info("Finished scanning log files. Total log files: {}, Total log
blocks: {}, Total rollbacks: {}, Total corrupt blocks: {}",
Review Comment:
can we print the partition and fileId of interest. and if possible base
instant time as well.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -566,6 +568,8 @@ &&
compareTimestamps(logBlock.getLogBlockHeader().get(INSTANT_TIME), GREATER_THA
// Eat exception as we do not want to mask the original exception that
can happen
LOG.error("Unable to close log format reader", ioe);
}
+ LOG.info("Finished scanning log files. Total log files: {}, Total log
blocks: {}, Total rollbacks: {}, Total corrupt blocks: {}",
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
