yihua commented on code in PR #14357:
URL: https://github.com/apache/hudi/pull/14357#discussion_r2569940870
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java:
##########
@@ -75,6 +75,11 @@ public SpillableMapBasedFileSystemView(HoodieTableMetadata
tableMetadata, Hoodie
new File(baseStoreDir).mkdirs();
diskMapType = commonConfig.getSpillableDiskMapType();
isBitCaskDiskMapCompressionEnabled =
commonConfig.isBitCaskDiskMapCompressionEnabled();
+ LOG.info("Initializing SpillableMapBasedFileSystemView with memory
configs: "
+ + "maxMemoryForFileGroupMap={}, maxMemoryForPendingCompaction={},
maxMemoryForPendingLogCompaction={}, "
+ + "maxMemoryForReplaceFileGroups={},
maxMemoryForClusteringFileGroups={}, baseStoreDir={}",
+ maxMemoryForFileGroupMap, maxMemoryForPendingCompaction,
maxMemoryForPendingLogCompaction,
+ maxMemoryForReplaceFileGroups, maxMemoryForClusteringFileGroups,
baseStoreDir);
Review Comment:
Also log `maxMemoryForBootstrapBaseFile`?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java:
##########
@@ -91,7 +96,7 @@ public SpillableMapBasedFileSystemView(HoodieTableMetadata
tableMetadata,
@Override
protected Map<String, List<HoodieFileGroup>> createPartitionToFileGroups() {
try {
- LOG.info("Creating Partition To File groups map using external spillable
Map. Max Mem={}, BaseDir={}", maxMemoryForFileGroupMap, baseStoreDir);
+ LOG.debug("Creating Partition To File groups map using external
spillable Map. Max Mem={}, BaseDir={}", maxMemoryForFileGroupMap, baseStoreDir);
Review Comment:
Should the remaining logging be removed as the log in the constructor
already covers these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
