the-other-tim-brown commented on code in PR #14364:
URL: https://github.com/apache/hudi/pull/14364#discussion_r2585713513
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/SourceFormatAdapter.java:
##########
@@ -127,8 +128,8 @@ private boolean getUseJava8api() {
* @return
*/
private JavaRDD<GenericRecord>
transformJsonToGenericRdd(InputBatch<JavaRDD<String>> inputBatch) {
-
MercifulJsonConverter.clearCache(inputBatch.getSchemaProvider().getSourceSchema().getFullName());
- AvroConvertor convertor = new
AvroConvertor(inputBatch.getSchemaProvider().getSourceSchema(),
isFieldNameSanitizingEnabled(), getInvalidCharMask());
+
MercifulJsonConverter.clearCache(inputBatch.getSchemaProvider().getSourceHoodieSchema().getFullName());
+ AvroConvertor convertor = new
AvroConvertor(inputBatch.getSchemaProvider().getSourceHoodieSchema().toAvroSchema(),
isFieldNameSanitizingEnabled(), getInvalidCharMask());
Review Comment:
The AvroConverter assumes that the schema is non-null today
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -337,7 +338,7 @@ public StreamSync(HoodieStreamer.Config cfg, SparkSession
sparkSession,
Source source = UtilHelpers.createSource(cfg.sourceClassName, props,
hoodieSparkContext.jsc(), sparkSession, metrics, streamContext);
this.formatAdapter = new SourceFormatAdapter(source,
this.errorTableWriter, Option.of(props));
- Supplier<Option<Schema>> schemaSupplier = schemaProvider == null ?
Option::empty : () -> Option.ofNullable(schemaProvider.getSourceSchema());
+ Supplier<Option<Schema>> schemaSupplier = schemaProvider == null ?
Option::empty : () ->
Option.ofNullable(schemaProvider.getSourceHoodieSchema().toAvroSchema());
Review Comment:
Updating this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
