the-other-tim-brown commented on code in PR #14364:
URL: https://github.com/apache/hudi/pull/14364#discussion_r2587157434
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/FilebasedSchemaProvider.java:
##########
@@ -70,31 +70,31 @@ public FilebasedSchemaProvider(TypedProperties props,
JavaSparkContext jssc) {
}
}
- private Schema parseSchema(String schemaFile) {
+ private HoodieSchema parseSchema(String schemaFile) {
return readSchemaFromFile(schemaFile, this.fs, config);
}
@Override
- public Schema getSourceSchema() {
+ public HoodieSchema getSourceHoodieSchema() {
Review Comment:
That's a good point. Should we just delegate for now on the actual
implementations? We can have the integration point with the rest of the code be
through HoodieSchema while keeping these calls delegate to the older methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
