yihua commented on code in PR #14344:
URL: https://github.com/apache/hudi/pull/14344#discussion_r2597309843
##########
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/util/TestHiveSchemaUtil.java:
##########
@@ -44,82 +44,55 @@ public class TestHiveSchemaUtil {
*/
@Test
public void testSchemaConvertArray() throws IOException {
- // Testing the 3-level annotation structure
- MessageType schema =
Types.buildMessage().optionalGroup().as(OriginalType.LIST).repeatedGroup()
-
.optional(PrimitiveType.PrimitiveTypeName.INT32).named("element").named("list").named("int_list")
- .named("ArrayOfInts");
+ // A list of integers
Review Comment:
Should we add more unit tests as some field conversion logic is not covered
by the tests in `TestHiveSchemaUtil`?
<img width="1033" height="715" alt="Screenshot 2025-12-07 at 23 16 14"
src="https://github.com/user-attachments/assets/5f042189-783b-4011-b7b3-d2210fdf31fe";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
