the-other-tim-brown commented on code in PR #14344:
URL: https://github.com/apache/hudi/pull/14344#discussion_r2598993236
##########
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/util/TestHiveSchemaUtil.java:
##########
@@ -44,82 +44,55 @@ public class TestHiveSchemaUtil {
*/
@Test
public void testSchemaConvertArray() throws IOException {
- // Testing the 3-level annotation structure
- MessageType schema =
Types.buildMessage().optionalGroup().as(OriginalType.LIST).repeatedGroup()
-
.optional(PrimitiveType.PrimitiveTypeName.INT32).named("element").named("list").named("int_list")
- .named("ArrayOfInts");
+ // A list of integers
Review Comment:
I wrote out more test cases against the master branch to generate the
expected outputs (casing is different based on field type) and then added it to
this branch. Thanks for calling this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
