vinothchandar commented on a change in pull request #2398:
URL: https://github.com/apache/hudi/pull/2398#discussion_r551190555
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -242,28 +246,41 @@ public Configuration getHadoopConf() {
* Get the view of the file system for this table.
*/
public TableFileSystemView getFileSystemView() {
- return new HoodieTableFileSystemView(metaClient,
getCompletedCommitsTimeline());
+ if (config.useFileListingMetadata()) {
+ return getFileSystemViewInternal(getCompletedCommitsTimeline());
+ } else {
+ return new HoodieTableFileSystemView(metaClient,
getCompletedCommitsTimeline());
+ }
}
/**
* Get the base file only view of the file system for this table.
*/
public BaseFileOnlyView getBaseFileOnlyView() {
- return getViewManager().getFileSystemView(metaClient);
+ return
getFileSystemViewInternal(metaClient.getActiveTimeline().filterCompletedAndCompactionInstants());
}
/**
* Get the full view of the file system for this table.
*/
public SliceView getSliceView() {
- return getViewManager().getFileSystemView(metaClient);
+ return
getFileSystemViewInternal(metaClient.getActiveTimeline().filterCompletedAndCompactionInstants());
}
/**
* Get complete view of the file system for this table with ability to force
sync.
*/
public SyncableFileSystemView getHoodieView() {
- return getViewManager().getFileSystemView(metaClient);
+ return
getFileSystemViewInternal(metaClient.getActiveTimeline().filterCompletedAndCompactionInstants());
+ }
+
+ private SyncableFileSystemView getFileSystemViewInternal(HoodieTimeline
timeline) {
+ if (config.useFileListingMetadata()) {
+ FileSystemViewStorageConfig viewConfig = config.getViewStorageConfig();
+ return new HoodieMetadataFileSystemView(metaClient, this.metadata(),
timeline, viewConfig.isIncrementalTimelineSyncEnabled());
+ } else {
+ return getViewManager().getFileSystemView(metaClient);
Review comment:
Hmmm. good point. I am not sure if that will work well, with timeline
server etc. best to keep it like this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
