vinothchandar commented on a change in pull request #2398:
URL: https://github.com/apache/hudi/pull/2398#discussion_r551192949
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/fs/HoodieWrapperFileSystem.java
##########
@@ -389,28 +456,28 @@ public Path resolvePath(Path p) throws IOException {
@Override
public FSDataInputStream open(Path f) throws IOException {
- return fileSystem.open(convertToDefaultPath(f));
+ return wrapInputStream(f, fileSystem.open(convertToDefaultPath(f)));
}
@Override
public FSDataOutputStream createNonRecursive(Path f, boolean overwrite, int
bufferSize, short replication,
- long blockSize, Progressable progress) throws IOException {
+ long blockSize, Progressable
progress) throws IOException {
Path p = convertToDefaultPath(f);
return wrapOutputStream(p,
fileSystem.createNonRecursive(p, overwrite, bufferSize, replication,
blockSize, progress));
}
@Override
public FSDataOutputStream createNonRecursive(Path f, FsPermission
permission, boolean overwrite, int bufferSize,
- short replication, long blockSize, Progressable progress) throws
IOException {
+ short replication, long
blockSize, Progressable progress) throws IOException {
Path p = convertToDefaultPath(f);
return wrapOutputStream(p,
fileSystem.createNonRecursive(p, permission, overwrite, bufferSize,
replication, blockSize, progress));
}
@Override
public FSDataOutputStream createNonRecursive(Path f, FsPermission
permission, EnumSet<CreateFlag> flags,
- int bufferSize, short replication, long blockSize, Progressable
progress) throws IOException {
+ int bufferSize, short
replication, long blockSize, Progressable progress) throws IOException {
Path p = convertToDefaultPath(f);
Review comment:
we should just automate this IMO. long pending. Our checkstyle does not
enforce wrapping and IDEs go their own thing. We can chat offline, if you are
interested. cc @xushiyan as well, who was thinking of running point on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
