rahil-c commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2617423850
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableChangeColumnCommand.scala:
##########
@@ -86,10 +85,10 @@ case class AlterHoodieTableChangeColumnCommand(
Seq.empty[Row]
}
- private def validateSchema(newSchema: Schema, metaClient:
HoodieTableMetaClient): Unit = {
+ private def validateSchema(newSchema: HoodieSchema, metaClient:
HoodieTableMetaClient): Unit = {
val schemaUtil = new TableSchemaResolver(metaClient)
- val tableSchema =
HoodieAvroUtils.createHoodieWriteSchema(schemaUtil.getTableAvroSchema(false))
- if (!AvroSchemaUtils.isSchemaCompatible(tableSchema, newSchema)) {
+ val tableSchema =
HoodieSchemaUtils.createHoodieWriteSchema(schemaUtil.getTableSchema(false).toString,
false)
Review Comment:
Currently the util only takes in a string
<img width="1302" height="484" alt="Screenshot 2025-12-14 at 11 29 15 AM"
src="https://github.com/user-attachments/assets/775a2a13-b66f-45da-afba-8bbfe2c9cae6";
/>
Is the ask then to just make a util that directly operates on the
HoodieSchema object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
