rahil-c commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2617433717
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/AvroConversionUtils.scala:
##########
@@ -50,7 +51,7 @@ object AvroConversionUtils {
* @return converter accepting Avro payload and transforming it into a
Catalyst one (in the form of [[InternalRow]])
*/
def createAvroToInternalRowConverter(rootAvroType: Schema, rootCatalystType:
StructType): GenericRecord => Option[InternalRow] = {
Review Comment:
I thought we were using the equivalent
`createGenericRecordToInternalRowConverter` inside the
`HoodieSchemaConversionUtils`
https://github.com/apache/hudi/pull/17573#discussion_r2612013328? Or is better
to remove the hoodischema util method and just modify the
`createAvroToInternalRowConverter` instead to take HoodieSchema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
