the-other-tim-brown commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2623543599
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -563,15 +563,15 @@ object ExpressionPayload {
}
}
- private def mergeSchema(a: Schema, b: Schema): Schema = {
+ private def mergeSchema(a: HoodieSchema, b: HoodieSchema): HoodieSchema = {
val mergedFields =
a.getFields.asScala.map(field =>
- createNewSchemaField("source_" + field.name,
- field.schema, field.doc, field.defaultVal, field.order)) ++
+ HoodieSchemaField.of("source_" + field.name(),
Review Comment:
Let's use the util here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
