rahil-c commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2624411003
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -483,15 +483,15 @@ object ExpressionPayload {
avroDeserializerCache.get()
.get(schema, new Function[Schema, HoodieAvroDeserializer] {
override def apply(t: Schema): HoodieAvroDeserializer =
- sparkAdapter.createAvroDeserializer(schema,
convertAvroSchemaToStructType(schema))
+
sparkAdapter.createAvroDeserializer(HoodieSchema.fromAvroSchema(schema),
convertHoodieSchemaToDataType(HoodieSchema.fromAvroSchema(schema)))
})
}
private def getAvroSerializerFor(schema: Schema) = {
Review Comment:
Will try to make this change for this class only to have caches take in
HoodieSchema. However i think my concern is this might cascade and touch other
classes potentially(will give first attempt).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
