yihua commented on code in PR #17630:
URL: https://github.com/apache/hudi/pull/17630#discussion_r2628488945
##########
hudi-common/src/main/java/org/apache/hudi/expression/Literal.java:
##########
@@ -80,22 +85,9 @@ public static <V> Literal from(V value) {
+ value.getClass().getName() + " to Literal");
}
+ @Getter
Review Comment:
No need to add this as the `@Getter` is annotated to the class.
##########
hudi-common/src/main/java/org/apache/hudi/expression/BinaryExpression.java:
##########
@@ -18,36 +18,23 @@
package org.apache.hudi.expression;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+
import java.util.Arrays;
import java.util.List;
/**
* The expression that accept two child expressions.
*/
+@AllArgsConstructor
Review Comment:
Should the access level be set to `PACKAGE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
