yihua commented on code in PR #17630:
URL: https://github.com/apache/hudi/pull/17630#discussion_r2628507218
##########
hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java:
##########
@@ -575,31 +555,11 @@ private static HoodieTableMetadata createMetadataTable(
* Partition path information containing the relative partition path
* and values of partition columns.
*/
- public static final class PartitionPath implements Serializable {
-
- final String path;
- final Object[] values;
-
- public PartitionPath(String path, Object[] values) {
- this.path = path;
- this.values = values;
- }
-
- public String getPath() {
- return path;
- }
-
- @Override
- public boolean equals(Object other) {
- return other instanceof PartitionPath
- && Objects.equals(path, ((PartitionPath) other).path)
- && Arrays.equals(values, ((PartitionPath) other).values);
- }
+ @Value
+ public static class PartitionPath implements Serializable {
- @Override
- public int hashCode() {
- return path.hashCode() * 1103 + Arrays.hashCode(values);
Review Comment:
Is there any significance of the `1103` value here when generating the hash
code?
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/DataGenerationPlan.java:
##########
Review Comment:
Lombok supports `@Builder`. Should we do another sweep to remove
boilerplate code for builders in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
