xushiyan commented on code in PR #487:
URL: https://github.com/apache/hudi-rs/pull/487#discussion_r2638070699
##########
.github/workflows/ci.yml:
##########
@@ -49,6 +49,129 @@ concurrency:
cancel-in-progress: true
jobs:
+ prepare-integration-build:
Review Comment:
this job currently adds 7min overhead before running integ test. pls see how
to optimize. for eg, if you have pre-built image, then no need to pull base and
prepare. the pre-built image should be directly used for the docker compose
stack.
##########
demo/infra/runner/Dockerfile:
##########
@@ -36,6 +37,10 @@ ENV PATH="/opt/.venv/bin:$PATH"
RUN uv pip install --only-binary=all 'pyarrow==20.0.0'
+# Make Python installation and venv accessible to any user (needed for
HOST_UID:HOST_GID mapping)
+# Python needs read+execute, venv needs read+write+execute for pip install
+RUN chmod -R a+rX /opt/python && chmod -R a+rwX /opt/.venv
Review Comment:
can you pre-build this docker image and publish it in docker hub so it can
be pulled directly during CI? once everything passed, I can re-publish the same
image under Hudi's official docker hub
##########
.github/workflows/ci.yml:
##########
@@ -200,7 +333,7 @@ jobs:
if: github.event.pull_request.user.login != 'dependabot[bot]'
steps:
- uses: actions/checkout@v6
- - uses: actions/download-artifact@v5
+ - uses: actions/download-artifact@v4
Review Comment:
why downgrade?
##########
demo/compose.yaml:
##########
@@ -70,6 +71,3 @@ services:
AWS_ALLOW_HTTP: true
AWS_REGION: us-east-1 # minio default
-networks:
- demo_network:
- driver: bridge
Review Comment:
what is the impact of removing this network setup?
##########
.gitignore:
##########
@@ -19,6 +19,10 @@
/target
**/target
+# CI/Docker cache directories
+.cargo/
+.uv-cache/
+
Review Comment:
why would this matter for CI? also we are keeping `.cargo/config.toml` for
the repo
##########
.github/workflows/pr.yml:
##########
@@ -46,5 +46,4 @@ jobs:
- name: Labeling
uses: actions/labeler@v6
- # disable until figuring out a way to do this without
pull_request_target
- if: false
+ if: false # Temporarily disabled - permissions issue
Review Comment:
revert this change. we don't touch labeler for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
