xushiyan commented on code in PR #487: URL: https://github.com/apache/hudi-rs/pull/487#discussion_r2640508692
########## demo/ci_run.sh: ########## @@ -25,7 +25,35 @@ export COMPOSE_DOCKER_CLI_BUILD=1 export HOST_UID=$(id -u) export HOST_GID=$(id -g) -docker compose up --build -d +# Check for cached build flag (pre-compiled artifacts available in mounted volume) +USE_CACHED_BUILD=false +if [ "$2" = "--use-cached-build" ]; then + USE_CACHED_BUILD=true +fi + +# Start services with or without rebuild +if [ "$USE_CACHED_BUILD" = "true" ]; then + # In CI, the runner image is pre-built and tagged as demo-runner:cached + # Note: we still need to build mc (minio client) as it's not cached, but it's small Review Comment: you probably want to look into those github action steps like download artifact which may already handle caching so that we don't need to maintain caching logic outside GH workflows. the goal is to minimize the script for easy maintenance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
