CTTY commented on PR #17661: URL: https://github.com/apache/hudi/pull/17661#issuecomment-3683962718
Hi @KiteSoar @yihua , I'm having second thoughts on this change now. Initially I was thinking of something like: ``` factory.withPath().withConf().build() ``` And then we can slowly migrate the entry point of storage from just `HoodieStorage` to `HoodieStorageFactory`. But I think this may be too intrusive no matter how we do it. It makes more sense to me right now that we don't add a new `HoodieStorageFactory` and keep the existing `HoodieStorageUtils`. **In this PR, we only need to switch the usages of `HoodieHadoopStorage` constructor to `HoodieStorageUtils` whenever possible.** I still want to stop people from using the `HoodieHadoopStorage` constructor directly but I don't have a good solution right now. The only idea in my mind is to set the constructor to be `default` visibility and use reflection when you can only use `HoodieHadoopStorage`, but I think this is anti-pattern and deserves a separate thread to discuss. Please let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
