KiteSoar commented on PR #17661: URL: https://github.com/apache/hudi/pull/17661#issuecomment-3684824326
> > It makes more sense to me right now that we don't add a new `HoodieStorageFactory` and keep the existing `HoodieStorageUtils`. **In this PR, we only need to switch the usages of `HoodieHadoopStorage` constructor to `HoodieStorageUtils` whenever possible.** > > Using existing `HoodieStorageUtils` to replace direct usages of `HoodieHadoopStorage` constructor makes sense to me. Right now `HoodieStorageUtils` serves as the factory for the `HoodieStorage`; the proposed `HoodieStorageFactory` can be a refactoring later, though not necessary at this point. Thanks for the review @CTTY @yihua. That makes sense. I agree with the suggestion to drop HoodieStorageFactory and stick with the existing HoodieStorageUtils. So, just to confirm the consensus: the goal of this PR is to switch the usages of the HoodieHadoopStorage constructor to HoodieStorageUtils wherever possible. I'll proceed with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
