CTTY commented on code in PR #17661:
URL: https://github.com/apache/hudi/pull/17661#discussion_r2648608229
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java:
##########
@@ -105,7 +106,8 @@ private static boolean checkIfHudiTable(final InputSplit
split, final JobConf jo
try {
Path inputPath = ((FileSplit) split).getPath();
FileSystem fs = inputPath.getFileSystem(job);
- HoodieStorage storage = new HoodieHadoopStorage(fs);
+ HoodieStorage storage = HoodieStorageUtils.getStorage(
Review Comment:
We should instead use
`HoodieStorageUtils.getStorage(HadoopFSUtils.convertToStoragePath(inputPath),
HadoopFSUtils.getStorageConf(fs.getConf())`
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/SchemaEvolutionContext.java:
##########
@@ -168,7 +168,8 @@ private Option<StoragePath> getTablePath(JobConf job,
InputSplit split) throws I
if (split instanceof FileSplit) {
Path path = ((FileSplit) split).getPath();
FileSystem fs = path.getFileSystem(job);
- HoodieStorage storage = new HoodieHadoopStorage(fs);
+ HoodieStorage storage = HoodieStorageUtils.getStorage(
Review Comment:
Same here, we should instead use
HoodieStorageUtils.getStorage(HadoopFSUtils.convertToStoragePath(path),
HadoopFSUtils.getStorageConf(fs.getConf())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
