rahil-c commented on code in PR #17660: URL: https://github.com/apache/hudi/pull/17660#discussion_r2650944296
########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieLanceRecordIterator.java: ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.io.storage; + +import com.lancedb.lance.file.LanceFileReader; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.vector.VectorSchemaRoot; +import org.apache.arrow.vector.ipc.ArrowReader; +import org.apache.hudi.common.util.collection.ClosableIterator; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.exception.HoodieIOException; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.catalyst.expressions.UnsafeProjection; +import org.apache.spark.sql.catalyst.expressions.UnsafeRow; +import org.apache.spark.sql.types.StructType; +import org.apache.spark.sql.vectorized.ColumnVector; +import org.apache.spark.sql.vectorized.ColumnarBatch; +import org.apache.spark.sql.vectorized.LanceArrowColumnVector; + +import java.io.IOException; +import java.util.Iterator; + +/** + * Shared iterator implementation for reading Lance files and converting Arrow batches to Spark rows. + * This iterator is used by both Hudi's internal Lance reader and Spark datasource integration. + * + * <p>The iterator manages the lifecycle of: + * <ul> + * <li>BufferAllocator - Arrow memory management</li> + * <li>LanceFileReader - Lance file handle</li> + * <li>ArrowReader - Arrow batch reader</li> + * <li>ColumnarBatch - Current batch being iterated</li> + * </ul> + * + * <p>Records are converted to {@link UnsafeRow} using {@link UnsafeProjection} for efficient + * serialization and memory management. + */ +public class HoodieLanceRecordIterator implements ClosableIterator<UnsafeRow> { Review Comment: @the-other-tim-brown @yihua @yihua It seems there is some pattern is to prefix with Hoodie for classes. <img width="532" height="406" alt="Screenshot 2025-12-29 at 8 11 31 AM" src="https://github.com/user-attachments/assets/affbe261-0f64-47fa-9758-7c4d4dad8251"; /> I am not opinionated on whether we have the prefix or not. ########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieLanceRecordIterator.java: ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.io.storage; + +import com.lancedb.lance.file.LanceFileReader; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.vector.VectorSchemaRoot; +import org.apache.arrow.vector.ipc.ArrowReader; +import org.apache.hudi.common.util.collection.ClosableIterator; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.exception.HoodieIOException; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.catalyst.expressions.UnsafeProjection; +import org.apache.spark.sql.catalyst.expressions.UnsafeRow; +import org.apache.spark.sql.types.StructType; +import org.apache.spark.sql.vectorized.ColumnVector; +import org.apache.spark.sql.vectorized.ColumnarBatch; +import org.apache.spark.sql.vectorized.LanceArrowColumnVector; + +import java.io.IOException; +import java.util.Iterator; + +/** + * Shared iterator implementation for reading Lance files and converting Arrow batches to Spark rows. + * This iterator is used by both Hudi's internal Lance reader and Spark datasource integration. + * + * <p>The iterator manages the lifecycle of: + * <ul> + * <li>BufferAllocator - Arrow memory management</li> + * <li>LanceFileReader - Lance file handle</li> + * <li>ArrowReader - Arrow batch reader</li> + * <li>ColumnarBatch - Current batch being iterated</li> + * </ul> + * + * <p>Records are converted to {@link UnsafeRow} using {@link UnsafeProjection} for efficient + * serialization and memory management. + */ +public class HoodieLanceRecordIterator implements ClosableIterator<UnsafeRow> { Review Comment: @the-other-tim-brown @yihua @nsivabalan It seems there is some pattern is to prefix with Hoodie for classes. <img width="532" height="406" alt="Screenshot 2025-12-29 at 8 11 31 AM" src="https://github.com/user-attachments/assets/affbe261-0f64-47fa-9758-7c4d4dad8251"; /> I am not opinionated on whether we have the prefix or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
