rahil-c commented on code in PR #17660:
URL: https://github.com/apache/hudi/pull/17660#discussion_r2650957828
##########
hudi-spark-datasource/hudi-spark3.4.x/src/main/scala/org/apache/spark/sql/adapter/Spark3_4Adapter.scala:
##########
@@ -154,6 +154,13 @@ class Spark3_4Adapter extends BaseSpark3Adapter {
Spark34OrcReader.build(vectorized, sqlConf, options, hadoopConf,
dataSchema)
}
+ override def createLanceFileReader(vectorized: Boolean,
+ sqlConf: SQLConf,
+ options: Map[String, String],
+ hadoopConf: Configuration):
SparkColumnarFileReader = {
+ throw new UnsupportedOperationException("Lance format is not supported in
Spark 3.4")
Review Comment:
When I discussed with @yihua I believe we only wanted to support lance for
the latest two versions in hudi spark(3.5, 4.0).
In terms of what lance supports from the docs there is support for 3.4 and
beyond https://lance.org/integrations/spark/install/#scala, so if we feel that
we should include spark 3.4.0 then will add this.
<img width="1066" height="456" alt="Screenshot 2025-12-29 at 8 20 01 AM"
src="https://github.com/user-attachments/assets/aa23910e-3f9f-4afe-9709-1e4ab8bbf04b";
/>
cc @the-other-tim-brown @nsivabalan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
