voonhous commented on code in PR #17763:
URL: https://github.com/apache/hudi/pull/17763#discussion_r2656076758
##########
hudi-common/src/main/java/org/apache/hudi/common/util/FileFormatUtils.java:
##########
@@ -315,7 +314,7 @@ public abstract ClosableIterator<Pair<HoodieKey, Long>>
fetchRecordKeysWithPosit
* @param filePath the data file path.
* @return the Avro schema of the data file.
*/
- public abstract Schema readAvroSchema(HoodieStorage storage, StoragePath
filePath);
+ public abstract HoodieSchema readHoodieSchema(HoodieStorage storage,
StoragePath filePath);
Review Comment:
Tried doing this initially, but it conflicts with `ParquetUtils#readSchema`
which returns a `MessageType`.
I will rename `ParquetUtils#readSchema` to `ParquetUtils#readMessageType` so
that this abstract `readHoodieSchema` can be renamed to `readSchema`.
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
