voonhous commented on code in PR #17763:
URL: https://github.com/apache/hudi/pull/17763#discussion_r2656142558
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestParquetUtils.java:
##########
@@ -358,17 +356,14 @@ private void writeParquetFile(String typeCode, String
filePath, List<String> row
writer.close();
}
- private static Schema getSchemaWithFields(List<String> fields) {
- List<Schema.Field> toBeAddedFields = new ArrayList<>();
- Schema recordSchema = Schema.createRecord("HoodieRecordKey", "", "",
false);
-
+ private static HoodieSchema getSchemaWithFields(List<String> fields) {
+ List<HoodieSchemaField> toBeAddedFields = new ArrayList<>();
for (String field: fields) {
- Schema.Field schemaField =
- new Schema.Field(field, METADATA_FIELD_SCHEMA, "",
JsonProperties.NULL_VALUE);
Review Comment:
Yeap, addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
