voonhous commented on code in PR #17763:
URL: https://github.com/apache/hudi/pull/17763#discussion_r2656143317
##########
hudi-hadoop-common/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java:
##########
@@ -340,14 +339,13 @@ public void testUnionOfTwoTypes() throws Exception {
@Test
public void testArrayOfOptionalRecords() throws Exception {
- Schema innerRecord = Schema.createRecord("element", null, null, false);
- Schema optionalString = optional(Schema.create(Schema.Type.STRING));
- innerRecord.setFields(Arrays.asList(
- new Schema.Field("s1", optionalString, null,
JsonProperties.NULL_VALUE),
- new Schema.Field("s2", optionalString, null,
JsonProperties.NULL_VALUE)));
- Schema schema = Schema.createRecord("HasArray", null, null, false);
- schema.setFields(
- Arrays.asList(new Schema.Field("myarray",
Schema.createArray(optional(innerRecord)), null, null)));
+ HoodieSchema optionalString =
HoodieSchema.createNullable(HoodieSchema.create(HoodieSchemaType.STRING));
+ List<HoodieSchemaField> innerRecordFields = Arrays.asList(
+ HoodieSchemaField.of("s1", optionalString, null,
JsonProperties.NULL_VALUE),
Review Comment:
Yeap. Removed the import and updated the other references to
`JsonProperties.NULL_VALUE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
