the-other-tim-brown commented on code in PR #17740:
URL: https://github.com/apache/hudi/pull/17740#discussion_r2656623732
##########
hudi-common/src/main/java/org/apache/hudi/avro/processors/DecimalLogicalTypeProcessor.java:
##########
@@ -34,15 +34,15 @@ public abstract class DecimalLogicalTypeProcessor extends
JsonFieldProcessor {
/**
* Check if the given schema is a valid decimal type configuration.
*/
- protected static boolean isValidDecimalTypeConfig(Schema schema) {
- LogicalTypes.Decimal decimalType = (LogicalTypes.Decimal)
schema.getLogicalType();
+ protected static boolean isValidDecimalTypeConfig(HoodieSchema schema) {
+ LogicalTypes.Decimal decimalType = (LogicalTypes.Decimal)
schema.toAvroSchema().getLogicalType();
Review Comment:
I'm not really following this comment, is there anything needed in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
