the-other-tim-brown commented on code in PR #17740:
URL: https://github.com/apache/hudi/pull/17740#discussion_r2656717800
##########
hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java:
##########
@@ -221,20 +210,20 @@ protected JsonFieldProcessor getProcessorForSchema(Schema
schema) {
/**
* Build type processor map for each avro type.
*/
- private Map<Schema.Type, JsonFieldProcessor> getFieldTypeProcessors() {
- Map<Schema.Type, JsonFieldProcessor> fieldTypeProcessors = new
EnumMap<>(Schema.Type.class);
- fieldTypeProcessors.put(Type.STRING, generateStringTypeHandler());
- fieldTypeProcessors.put(Type.BOOLEAN, generateBooleanTypeHandler());
- fieldTypeProcessors.put(Type.DOUBLE, generateDoubleTypeHandler());
- fieldTypeProcessors.put(Type.FLOAT, generateFloatTypeHandler());
- fieldTypeProcessors.put(Type.INT, generateIntTypeHandler());
- fieldTypeProcessors.put(Type.LONG, generateLongTypeHandler());
- fieldTypeProcessors.put(Type.ARRAY, generateArrayTypeHandler());
- fieldTypeProcessors.put(Type.RECORD, generateRecordTypeHandler());
- fieldTypeProcessors.put(Type.ENUM, generateEnumTypeHandler());
- fieldTypeProcessors.put(Type.MAP, generateMapTypeHandler());
- fieldTypeProcessors.put(Type.BYTES, generateBytesTypeHandler());
- fieldTypeProcessors.put(Type.FIXED, generateFixedTypeHandler());
+ private Map<HoodieSchemaType, JsonFieldProcessor> getFieldTypeProcessors() {
+ Map<HoodieSchemaType, JsonFieldProcessor> fieldTypeProcessors = new
EnumMap<>(HoodieSchemaType.class);
+ fieldTypeProcessors.put(HoodieSchemaType.STRING,
generateStringTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.BOOLEAN,
generateBooleanTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.DOUBLE,
generateDoubleTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.FLOAT,
generateFloatTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.INT, generateIntTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.LONG, generateLongTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.ARRAY,
generateArrayTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.RECORD,
generateRecordTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.ENUM, generateEnumTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.MAP, generateMapTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.BYTES,
generateBytesTypeHandler());
+ fieldTypeProcessors.put(HoodieSchemaType.FIXED,
generateFixedTypeHandler());
Review Comment:
Is this ok as it is then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
