the-other-tim-brown commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2659011303
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/CopyOnWriteInsertHandler.java:
##########
@@ -82,7 +82,7 @@ public void consume(HoodieInsertValueGenResult<HoodieRecord>
genResult) {
String partitionPath = record.getPartitionPath();
// just skip the ignored record，do not make partitions on fs
try {
- if (record.shouldIgnore(genResult.schema, config.getProps())) {
+ if (record.shouldIgnore(HoodieSchema.fromAvroSchema(genResult.schema),
config.getProps())) {
Review Comment:
The task calls out that `Related classes that should also be targeted in
this PR: HoodieInsertValueGenResult` - let's do this all in one PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
