the-other-tim-brown commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2660034099
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieFlinkRecord.java:
##########
@@ -158,13 +159,13 @@ protected RowData readRecordPayload(Kryo kryo, Input
input) {
}
@Override
- public Object convertColumnValueForLogicalType(Schema fieldSchema,
+ public Object convertColumnValueForLogicalType(HoodieSchema fieldSchema,
Object fieldValue,
boolean
keepConsistentLogicalTimestamp) {
if (fieldValue == null) {
return null;
}
- LogicalType logicalType = fieldSchema.getLogicalType();
+ LogicalType logicalType = fieldSchema.toAvroSchema().getLogicalType();
Review Comment:
Let's update this to use the HoodieSchemaType as well.
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java:
##########
@@ -18,6 +18,7 @@
package org.apache.hudi.common.model;
+import org.apache.hudi.common.schema.HoodieSchema;
Review Comment:
We should be able to remove the `import org.apache.avro.Schema;` with this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
