lokeshj1703 commented on code in PR #17601:
URL: https://github.com/apache/hudi/pull/17601#discussion_r2652989211
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieAvroDataBlock.java:
##########
@@ -156,7 +157,7 @@ private static class RecordIterator implements
ClosableIterator<IndexedRecord> {
private int totalRecords = 0;
private int readRecords = 0;
- private RecordIterator(Schema readerSchema, Schema writerSchema, byte[]
content) throws IOException {
+ private RecordIterator(Schema readerSchema, Schema writerSchema, byte[]
content, boolean enableLogicalTimestampFieldRepair) throws IOException {
Review Comment:
This is always true. Can be omitted.
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -1040,12 +1051,35 @@ private static Object rewritePrimaryType(Object
oldValue, Schema oldSchema, Sche
case NULL:
case BOOLEAN:
case INT:
- case LONG:
case FLOAT:
case DOUBLE:
case BYTES:
case STRING:
return oldValue;
+ case LONG:
Review Comment:
Even these changes can be revisited. They may not be required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
