voonhous commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2660907918
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutorInSpark.java:
##########
@@ -136,7 +137,7 @@ public Integer finish() {
BoundedInMemoryExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> executor =
new BoundedInMemoryExecutor(writeConfig.getWriteBufferLimitBytes(),
hoodieRecords.iterator(), consumer,
- getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA,
writeConfig), getPreExecuteRunnable());
+
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig), getPreExecuteRunnable());
Review Comment:
`HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA)` ->
`HoodieTestDataGenerator.HOODIE_SCHEMA`
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -92,7 +93,7 @@ public void testRecordReading() throws Exception {
final int numRecords = 128;
final List<HoodieRecord> hoodieRecords =
dataGen.generateInserts(instantTime, numRecords);
final BoundedInMemoryQueue<HoodieRecord,
HoodieLazyInsertIterable.HoodieInsertValueGenResult> queue =
- new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutorInSpark.java:
##########
@@ -179,7 +180,7 @@ public Integer finish() {
BoundedInMemoryExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> executor =
new BoundedInMemoryExecutor(writeConfig.getWriteBufferLimitBytes(),
unboundedRecordIter,
- consumer,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig),
+ consumer,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig),
Review Comment:
`HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA)` ->
`HoodieTestDataGenerator.HOODIE_SCHEMA`
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestDisruptorMessageQueue.java:
##########
@@ -305,7 +306,7 @@ public Integer finish() {
};
DisruptorExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> exec = new DisruptorExecutor(1024,
- producers, consumer,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig),
+ producers, consumer,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig),
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -310,7 +311,7 @@ public void testException() throws Exception {
when(mockHoodieRecordsIterator.hasNext()).thenReturn(true);
when(mockHoodieRecordsIterator.next()).thenThrow(expectedException);
BoundedInMemoryQueue<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>> queue2 =
- new BoundedInMemoryQueue(memoryLimitInBytes,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(memoryLimitInBytes,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -274,15 +275,15 @@ public void testException() throws Exception {
final SizeEstimator<Tuple2<HoodieRecord, Option<IndexedRecord>>>
sizeEstimator = new DefaultSizeEstimator<>();
// queue memory limit
HoodieLazyInsertIterable.HoodieInsertValueGenResult genResult =
- getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA,
writeConfig).apply(hoodieRecords.get(0));
- final long objSize = sizeEstimator.sizeEstimate(new
Tuple2(genResult.getResult(),
genResult.getResult().toIndexedRecord(HoodieTestDataGenerator.AVRO_SCHEMA, new
Properties())));
+
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig).apply(hoodieRecords.get(0));
+ final long objSize = sizeEstimator.sizeEstimate(new
Tuple2(genResult.getResult(),
genResult.getResult().toIndexedRecord(HoodieTestDataGenerator.HOODIE_SCHEMA,
new Properties())));
final long memoryLimitInBytes = 4 * objSize;
// first let us throw exception from queueIterator reader and test that
queueing thread
// stops and throws
// correct exception back.
BoundedInMemoryQueue<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>> queue1 =
- new BoundedInMemoryQueue(memoryLimitInBytes,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(memoryLimitInBytes,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -225,11 +226,11 @@ public void testMemoryLimitForBuffering() throws
Exception {
final int recordLimit = 5;
final SizeEstimator<HoodieLazyInsertIterable.HoodieInsertValueGenResult>
sizeEstimator = new DefaultSizeEstimator<>();
HoodieLazyInsertIterable.HoodieInsertValueGenResult genResult =
- getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA,
writeConfig).apply(hoodieRecords.get(0));
+
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig).apply(hoodieRecords.get(0));
final long objSize = sizeEstimator.sizeEstimate(genResult);
final long memoryLimitInBytes = recordLimit * objSize;
final BoundedInMemoryQueue<HoodieRecord,
HoodieLazyInsertIterable.HoodieInsertValueGenResult> queue =
- new BoundedInMemoryQueue(memoryLimitInBytes,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(memoryLimitInBytes,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestDisruptorMessageQueue.java:
##########
@@ -128,7 +129,7 @@ public Integer finish() {
try {
exec = new
DisruptorExecutor(writeConfig.getWriteExecutorDisruptorWriteBufferLimitBytes(),
hoodieRecords.iterator(), consumer,
- getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA,
writeConfig), WaitStrategyFactory.DEFAULT_STRATEGY, getPreExecuteRunnable());
+
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig), WaitStrategyFactory.DEFAULT_STRATEGY, getPreExecuteRunnable());
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestDisruptorMessageQueue.java:
##########
@@ -157,7 +158,7 @@ public void testCompositeProducerRecordReading() throws
Exception {
final List<List<HoodieRecord>> recs = new ArrayList<>();
final DisruptorMessageQueue<HoodieRecord, HoodieInsertValueGenResult>
queue =
- new DisruptorMessageQueue(1024,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig),
+ new DisruptorMessageQueue(1024,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig),
Review Comment:
Same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -130,7 +131,7 @@ public void testCompositeProducerRecordReading() throws
Exception {
final List<List<HoodieRecord>> recs = new ArrayList<>();
final BoundedInMemoryQueue<HoodieRecord,
HoodieLazyInsertIterable.HoodieInsertValueGenResult> queue =
- new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
