KiteSoar commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2661534123
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -130,7 +131,7 @@ public void testCompositeProducerRecordReading() throws
Exception {
final List<List<HoodieRecord>> recs = new ArrayList<>();
final BoundedInMemoryQueue<HoodieRecord,
HoodieLazyInsertIterable.HoodieInsertValueGenResult> queue =
- new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
done
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -92,7 +93,7 @@ public void testRecordReading() throws Exception {
final int numRecords = 128;
final List<HoodieRecord> hoodieRecords =
dataGen.generateInserts(instantTime, numRecords);
final BoundedInMemoryQueue<HoodieRecord,
HoodieLazyInsertIterable.HoodieInsertValueGenResult> queue =
- new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig));
Review Comment:
done
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutorInSpark.java:
##########
@@ -179,7 +180,7 @@ public Integer finish() {
BoundedInMemoryExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> executor =
new BoundedInMemoryExecutor(writeConfig.getWriteBufferLimitBytes(),
unboundedRecordIter,
- consumer,
getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA, writeConfig),
+ consumer,
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig),
Review Comment:
done
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutorInSpark.java:
##########
@@ -136,7 +137,7 @@ public Integer finish() {
BoundedInMemoryExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> executor =
new BoundedInMemoryExecutor(writeConfig.getWriteBufferLimitBytes(),
hoodieRecords.iterator(), consumer,
- getTransformerInternal(HoodieTestDataGenerator.AVRO_SCHEMA,
writeConfig), getPreExecuteRunnable());
+
getTransformerInternal(HoodieSchema.fromAvroSchema(HoodieTestDataGenerator.AVRO_SCHEMA),
writeConfig), getPreExecuteRunnable());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
