danny0405 commented on code in PR #17807:
URL: https://github.com/apache/hudi/pull/17807#discussion_r2674815622
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -165,7 +165,7 @@ private void startServer(TimelineServiceCreator
timelineServiceCreator) throws I
.earlyConflictDetectionCheckCommitConflict(writeConfig.earlyConflictDetectionCheckCommitConflict())
.asyncConflictDetectorInitialDelayMs(writeConfig.getAsyncConflictDetectorInitialDelayMs())
.asyncConflictDetectorPeriodMs(writeConfig.getAsyncConflictDetectorPeriodMs())
- .earlyConflictDetectionMaxAllowableHeartbeatIntervalInMs(
+ .maxAllowableHeartbeatIntervalInMs(
Review Comment:
should we rename the maxAllowableHeartbeatIntervalInMs too to make the API
unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
