voonhous commented on code in PR #17807:
URL: https://github.com/apache/hudi/pull/17807#discussion_r2674828427
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -165,7 +165,7 @@ private void startServer(TimelineServiceCreator
timelineServiceCreator) throws I
.earlyConflictDetectionCheckCommitConflict(writeConfig.earlyConflictDetectionCheckCommitConflict())
.asyncConflictDetectorInitialDelayMs(writeConfig.getAsyncConflictDetectorInitialDelayMs())
.asyncConflictDetectorPeriodMs(writeConfig.getAsyncConflictDetectorPeriodMs())
- .earlyConflictDetectionMaxAllowableHeartbeatIntervalInMs(
+ .maxAllowableHeartbeatIntervalInMs(
Review Comment:
<img width="602" height="368" alt="image"
src="https://github.com/user-attachments/assets/f4d4e20a-2d75-447d-9c59-ccfeb432ba15";
/>
The original code uses `maxAllowableHeartbeatIntervalInMs` almost
everywhere. The only place where this config was renamed is in the builder
interface. Which is only used in 2 locations:
<img width="1029" height="147" alt="image"
src="https://github.com/user-attachments/assets/ca6ca2a4-1ef6-4b9a-a8e4-5a062e2decb5";
/>
I am in favour of keeping `maxAllowableHeartbeatIntervalInMs` so the entire
code base is more consistent as majority is using
`maxAllowableHeartbeatIntervalInMs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
