voonhous commented on code in PR #17823:
URL: https://github.com/apache/hudi/pull/17823#discussion_r2692925805
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieRepairTool.java:
##########
@@ -175,41 +174,39 @@ public boolean run() {
Option<String> endingInstantOption =
Option.ofNullable(cfg.endingInstantTime);
if (startingInstantOption.isPresent() && endingInstantOption.isPresent()) {
- LOG.info(String.format("Start repairing completed instants between %s
and %s (inclusive)",
- startingInstantOption.get(), endingInstantOption.get()));
+ log.info("Start repairing completed instants between {} and {}
(inclusive)",
+ startingInstantOption.get(), endingInstantOption.get());
} else if (startingInstantOption.isPresent()) {
- LOG.info(String.format("Start repairing completed instants from %s
(inclusive)",
- startingInstantOption.get()));
+ log.info("Start repairing completed instants from {} (inclusive)",
startingInstantOption.get());
} else if (endingInstantOption.isPresent()) {
- LOG.info(String.format("Start repairing completed instants till %s
(inclusive)",
- endingInstantOption.get()));
+ log.info("Start repairing completed instants till {} (inclusive)",
endingInstantOption.get());
} else {
- LOG.info("Start repairing all completed instants");
+ log.info("Start repairing all completed instants");
}
try {
Mode mode = Mode.valueOf(cfg.runningMode.toUpperCase());
switch (mode) {
case REPAIR:
- LOG.info(" ****** The repair tool is in REPAIR mode, dangling data
and logs files "
+ log.info(" ****** The repair tool is in REPAIR mode, dangling data
and logs files "
+ "not belonging to any commit are going to be DELETED from the
table ******");
if (checkBackupPathForRepair() < 0) {
- LOG.error("Backup path check failed.");
+ log.error("Backup path check failed.");
return false;
}
return doRepair(startingInstantOption, endingInstantOption, false);
case DRY_RUN:
- LOG.info(" ****** The repair tool is in DRY_RUN mode, "
+ log.info(" ****** The repair tool is in DRY_RUN mode, "
+ "only LOOKING FOR dangling data and log files from the table
******");
return doRepair(startingInstantOption, endingInstantOption, true);
case UNDO:
if (checkBackupPathAgainstBasePath() < 0) {
- LOG.error("Backup path check failed.");
+ log.error("Backup path check failed.");
return false;
}
return undoRepair();
default:
- LOG.info("Unsupported running mode [" + cfg.runningMode + "], quit
the job directly");
+ log.info("Unsupported running mode [" + cfg.runningMode + "], quit
the job directly");
Review Comment:
Done
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/TableSizeStats.java:
##########
@@ -374,7 +373,7 @@ private static List<String> getFilePaths(String propsPath,
Configuration hadoopC
line = reader.readLine();
}
} catch (IOException ioe) {
- LOG.error("Error reading in properties from dfs from file." + propsPath);
+ log.error("Error reading in properties from dfs from file.{}",
propsPath);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
