the-other-tim-brown commented on code in PR #17801:
URL: https://github.com/apache/hudi/pull/17801#discussion_r2692862918
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestDisruptorMessageQueue.java:
##########
@@ -128,7 +128,7 @@ public Integer finish() {
try {
exec = new
DisruptorExecutor(writeConfig.getWriteExecutorDisruptorWriteBufferLimitBytes(),
hoodieRecords.iterator(), consumer,
- getTransformerInternal(HOODIE_SCHEMA, writeConfig),
WaitStrategyFactory.DEFAULT_STRATEGY, getPreExecuteRunnable());
+ getTransformerInternal(HoodieTestDataGenerator.HOODIE_SCHEMA,
writeConfig), WaitStrategyFactory.DEFAULT_STRATEGY, getPreExecuteRunnable());
Review Comment:
And this one
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutorInSpark.java:
##########
@@ -96,7 +96,7 @@ public Integer finish() {
BoundedInMemoryExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> executor = null;
try {
executor = new
BoundedInMemoryExecutor(writeConfig.getWriteBufferLimitBytes(),
hoodieRecords.iterator(), consumer,
- getTransformerInternal(HOODIE_SCHEMA, writeConfig),
getPreExecuteRunnable());
+ getTransformerInternal(HoodieTestDataGenerator.HOODIE_SCHEMA,
writeConfig), getPreExecuteRunnable());
Review Comment:
The changes in this file can be removed now that there is an import for the
class
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java:
##########
@@ -93,7 +93,7 @@ public void testRecordReading() throws Exception {
final int numRecords = 128;
final List<HoodieRecord> hoodieRecords =
dataGen.generateInserts(instantTime, numRecords);
final BoundedInMemoryQueue<HoodieRecord,
HoodieLazyInsertIterable.HoodieInsertValueGenResult> queue =
- new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HOODIE_SCHEMA, writeConfig));
+ new BoundedInMemoryQueue(FileIOUtils.KB,
getTransformerInternal(HoodieTestDataGenerator.HOODIE_SCHEMA, writeConfig));
Review Comment:
Same with this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
