voonhous commented on code in PR #17801:
URL: https://github.com/apache/hudi/pull/17801#discussion_r2696884103
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -913,32 +908,6 @@ public static Schema getNullSchema() {
return Schema.create(Schema.Type.NULL);
}
- /**
- * Sanitizes Name according to Avro rule for names.
- * Removes characters other than the ones mentioned in
https://avro.apache.org/docs/current/spec.html#names .
- *
- * @param name input name
- * @return sanitized name
- */
- public static String sanitizeName(String name) {
Review Comment:
Moved to `HoodieSchemaUtils`
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java:
##########
@@ -489,53 +488,6 @@ public static String getHudiSchemaVersion() {
return version != null ? version : "unknown";
}
- /**
Review Comment:
Duplicated methods that already exist in `HoodieSchemaUtils`, removing them.
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -115,10 +114,6 @@ public class HoodieAvroUtils {
//Export for test
public static final Conversions.DecimalConversion DECIMAL_CONVERSION = new
Conversions.DecimalConversion();
- // As per https://avro.apache.org/docs/current/spec.html#names
Review Comment:
Moved to `HoodieSchemaUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
