danny0405 commented on code in PR #17604:
URL: https://github.com/apache/hudi/pull/17604#discussion_r2693104906
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/format/FlinkRecordContext.java:
##########
@@ -148,7 +148,17 @@ public HoodieRecord<RowData>
constructHoodieRecord(BufferedRecord<RowData> buffe
@Override
public RowData constructEngineRecord(HoodieSchema recordSchema, Object[]
fieldValues) {
- return GenericRowData.of(fieldValues);
+ List<HoodieSchemaField> fields = recordSchema.getFields();
Review Comment:
checked that the `fieldValues` are initialized with the `recordSchema`
fields size, to the check is totally reduadant.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/format/FlinkRecordContext.java:
##########
@@ -148,7 +148,17 @@ public HoodieRecord<RowData>
constructHoodieRecord(BufferedRecord<RowData> buffe
@Override
public RowData constructEngineRecord(HoodieSchema recordSchema, Object[]
fieldValues) {
- return GenericRowData.of(fieldValues);
+ List<HoodieSchemaField> fields = recordSchema.getFields();
Review Comment:
checked that the `fieldValues` are initialized with the `recordSchema`
fields size, so the check is totally reduadant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
