PavithranRick commented on code in PR #17604:
URL: https://github.com/apache/hudi/pull/17604#discussion_r2726490238
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/format/FlinkRecordContext.java:
##########
@@ -148,7 +148,17 @@ public HoodieRecord<RowData>
constructHoodieRecord(BufferedRecord<RowData> buffe
@Override
public RowData constructEngineRecord(HoodieSchema recordSchema, Object[]
fieldValues) {
- return GenericRowData.of(fieldValues);
+ List<HoodieSchemaField> fields = recordSchema.getFields();
+ if (fields.size() != fieldValues.length) {
+ throw new IllegalArgumentException(
+ "Value count (" + fieldValues.length + ") does not match field count
(" + fields.size() + ")");
+ }
+
+ GenericRowData genericRowData = new GenericRowData(fieldValues.length);
+ for (int index = 0; index < fields.size(); index++) {
+ genericRowData.setField(index, fieldValues[index]);
+ }
+ return toBinaryRow(recordSchema, genericRowData);
Review Comment:
Done. Agreed that BufferedRecord has a toBinary() method that converts to
binary when needed, so records don't need to be binary from the start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
