danny0405 commented on code in PR #17838:
URL: https://github.com/apache/hudi/pull/17838#discussion_r2706712605
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1227,6 +1227,12 @@ public void startCommit(String instantTime) {
getWriteClient().startCommitForMetadataTable(metadataMetaClient,
instantTime, HoodieTimeline.DELTA_COMMIT_ACTION);
}
+ @Override
+ public void stopCommit(String instantTime) {
+ // stop the heart beat of instant.
+ getWriteClient().getHeartbeatClient().stop(instantTime);
Review Comment:
should we just stop the heartbeat in the `#close` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
