danny0405 commented on code in PR #17838:
URL: https://github.com/apache/hudi/pull/17838#discussion_r2706730527
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -385,13 +395,13 @@ private CompletableFuture<CoordinationResponse>
handleInstantRequest(Corresponde
CompletableFuture<CoordinationResponse> response = new
CompletableFuture<>();
instantRequestExecutor.execute(() -> {
long checkpointId = request.getCheckpointId();
- Pair<String, WriteMetadataEvent[]> instantTimeAndEventBuffer =
this.eventBuffers.getInstantAndEventBuffer(checkpointId);
+ Pair<String, Pair<WriteMetadataEvent[], WriteMetadataEvent[]>>
instantTimeAndEventBuffer =
this.eventBuffers.getInstantAndEventBuffer(checkpointId);
Review Comment:
consider to introudce new POJO instead of using Pair, this may also break
the state compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
