nsivabalan commented on code in PR #17520:
URL: https://github.com/apache/hudi/pull/17520#discussion_r2722160348
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -2952,8 +2943,7 @@ private void checkLogBlocksAndKeys(String
latestInstantTime, Schema schema, Exte
.withBufferSize(BUFFER_SIZE)
.withSpillableMapBasePath(spillableBasePath)
.withDiskMapType(diskMapType)
- .withBitCaskDiskMapCompressionEnabled(isCompressionEnabled)
- .withOptimizedLogBlocksScan(enableOptimizedLogBlocksScan);
+ .withBitCaskDiskMapCompressionEnabled(isCompressionEnabled);
Review Comment:
We need to revisit tests in this class like
`testBasicAppendAndScanMultipleFiles` and remove the parametrized test that
tests `enableOptimizedLogBlocksScan`
can you do one pass and fix them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
