suryaprasanna commented on code in PR #17520:
URL: https://github.com/apache/hudi/pull/17520#discussion_r2723171839
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieReaderConfig.java:
##########
@@ -45,14 +45,6 @@ public class HoodieReaderConfig extends HoodieConfig {
.withDocumentation("HoodieLogFormatReader reads a logfile in the forward
direction starting from pos=0 to pos=file_length. "
+ "If this config is set to true, the reader reads the logfile in
reverse direction, from pos=file_length to pos=0");
- public static final ConfigProperty<String> ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN
= ConfigProperty
- .key("hoodie" + HoodieMetadataConfig.OPTIMIZED_LOG_BLOCKS_SCAN)
- .defaultValue("false")
Review Comment:
@yihua Originally, scanV1 method directly reads the blocks without checking
if they are compacted or not. Optimized log block scan(scanV2) will first scan
through the blocks and then determine which of these blocks are valid and then
start reading them. But lately even scanV1 is doing lazy reading, similar to
scanV2.
So, there wont be any much of an overhead between them. Inaddition scanV2
has logic to support actions like logcompaction.
Example, if user used logcompaction once then traditional scan will result
is duplicate values. So, we need to default the optimzed log block scan as the
default option and dont see any merit in using scanV1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
