suryaprasanna commented on code in PR #17935:
URL: https://github.com/apache/hudi/pull/17935#discussion_r2723108776


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -151,6 +153,13 @@ public final class HoodieMetadataConfig extends 
HoodieConfig {
       .sinceVersion("0.14.0")
       .withDocumentation("Controls the criteria to log compacted files groups 
in metadata table.");
 
+  public static final ConfigProperty<String> CLEANER_POLICY = ConfigProperty
+      .key(METADATA_PREFIX + ".clean.policy")
+      .defaultValue(KEEP_LATEST_FILE_VERSIONS.name())
+      .markAdvanced()
+      .sinceVersion("1.2.0")
+      .withDocumentation("This config determines the cleaner policy for 
metadata table.");

Review Comment:
   I feel adding more configs will unnecessarily complicate the code. Let us 
just maintain one config for metadata cleaner policy, we can decide which one 
it should be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to